Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javascript Tracer resource leak #6929

Merged
merged 4 commits into from
Apr 18, 2024
Merged

Javascript Tracer resource leak #6929

merged 4 commits into from
Apr 18, 2024

Conversation

Marchhill
Copy link
Contributor

Changes

  • Ensure that tracer resources (ArrayPoolList) are disposed

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

LukaszRozmej
LukaszRozmej requested changes Apr 18, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using pattern > explicit Dispose calls.

...thermind/Nethermind.Evm/Tracing/GethStyle/Custom/JavaScript/GethLikeBlockJavaScriptTracer.cs Show resolved Hide resolved
src/Nethermind/Nethermind.Evm.Test/Tracing/GethLikeJavaScriptTracerTests.cs Outdated Show resolved Hide resolved
@LukaszRozmej LukaszRozmej changed the title Tracer resource leak Tracer resource leak (in tests) Apr 18, 2024
@LukaszRozmej LukaszRozmej changed the title Tracer resource leak (in tests) Javascript Tracer resource leak Apr 18, 2024
@LukaszRozmej LukaszRozmej merged commit cad37a7 into master Apr 18, 2024
67 checks passed
@LukaszRozmej LukaszRozmej deleted the fix/dispose-tracers branch April 18, 2024 15:08
kamilchodola pushed a commit that referenced this pull request Apr 23, 2024
@Marchhill @LukaszRozmej @kamilchodola
Javascript Tracer resource leak (#6929)
838fc79 
Co-authored-by: lukasz.rozmej <[email protected]>
@LukaszRozmej LukaszRozmej mentioned this pull request May 7, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebeauregard natebeauregard natebeauregard approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marchhill @LukaszRozmej @natebeauregard