Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load td for beacon block if possible to help handle multiple fcus sent with no delay #6878

Merged
merged 6 commits into from
Apr 11, 2024
Merged

Load td for beacon block if possible to help handle multiple fcus sent with no delay #6878

merged 6 commits into from
Apr 11, 2024

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Mar 29, 2024 •
edited
Loading

Partially fixes windows nethermind + lighthouse sync issue
Fixes last withdrawals hive test

Changes

  • Load td for beacon block if possible
  • Remember block number of a block sent to processing to get rid of triggering fast sync transition

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

@flcl42 flcl42 requested a review from asdacap March 29, 2024 09:01
MarekM25
MarekM25 previously requested changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use FinalTotalDifficulty from PosSwitcher? or generally share the logic. There are a few more cases here, not only hardcoded pivot

@flcl42 flcl42 marked this pull request as ready for review April 1, 2024 08:46
@flcl42 flcl42 requested review from MarekM25 and LukaszRozmej April 1, 2024 08:46
@flcl42 flcl42 force-pushed the bugfix/multiple-fcu-break-sync branch from 8e27d0d to 198ccd8 Compare April 1, 2024 09:30
@flcl42 flcl42 marked this pull request as draft April 3, 2024 11:08
@flcl42 flcl42 marked this pull request as ready for review April 9, 2024 16:33
@flcl42
Copy link
Contributor Author

flcl42 commented Apr 11, 2024

Can we use FinalTotalDifficulty from PosSwitcher? or generally share the logic. There are a few more cases here, not only hardcoded pivot

Fixed

@MarekM25 MarekM25 dismissed their stale review April 11, 2024 14:07

changes were made

@flcl42 flcl42 merged commit 68f7824 into master Apr 11, 2024
67 checks passed
@flcl42 flcl42 deleted the bugfix/multiple-fcu-break-sync branch April 11, 2024 14:08
@kamilchodola kamilchodola restored the bugfix/multiple-fcu-break-sync branch April 25, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcindsobczak marcindsobczak marcindsobczak approved these changes

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@asdacap asdacap Awaiting requested review from asdacap

@MarekM25 MarekM25 Awaiting requested review from MarekM25

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flcl42 @MarekM25 @LukaszRozmej @marcindsobczak