Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShaMerkleTree for multithreaded access #6687

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Fix ShaMerkleTree for multithreaded access #6687

merged 1 commit into from
Feb 11, 2024

Conversation

benaadams
Copy link
Member

Resolves #6684

Changes

  • Use different HashAlgorithm instance per thread

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)

Testing

Requires testing

  • No

@benaadams benaadams added the bug label Feb 11, 2024
@benaadams benaadams mentioned this pull request Feb 11, 2024
Closed
@benaadams benaadams merged commit f867496 into master Feb 11, 2024
67 checks passed
@benaadams benaadams deleted the ShaMerkleTree branch February 11, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ShaMerkleTree class uses SHA256 HashAlgorithm in a thread unsafe manner
2 participants
@benaadams @LukaszRozmej