-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancun spec and config for mainnet #6679
Cancun spec and config for mainnet #6679
Conversation
@marcindsobczak what do you think about luk's comments? |
Agree with @LukaszRozmej , we have 2048 as default TxPool size for many years and it works well (we tested 1k, 4k and 8k back then and chose 2k), no need to change it now (especially without benchmarking). About making
But if you want, we can merge it as it is (except 1024 for std TxPool) and I will handle it in separate PR |
@marcindsobczak ill address it in this PR. No problem |
Given the |
@rubo i think the idea is testnets usually run on lower spec machines. and that is why we have 1024 for testnets and 2048 for "mainnets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
* Resolved conflicts * max body size for http json rpc (#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (#6672) * Update txPool worst value if removal unsuccessful (#6702) * Add Cancun hard-fork settings for Gnosis (#6709) * Cancun spec and config for mainnet (#6679) * Add Paris release spec class for completeness (#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
* Resolved conflicts * max body size for http json rpc (NethermindEth#36) * Format * Self-recovery of TxPool max capacity * fix ProcessedTransactionsDbCleanerTests * Update txPool worst value if removal unsuccessful (NethermindEth#6702) (cherry picked from commit f262cb2) * Clearer error message for missing starting block state (NethermindEth#6672) * Update txPool worst value if removal unsuccessful (NethermindEth#6702) * Add Cancun hard-fork settings for Gnosis (NethermindEth#6709) * Cancun spec and config for mainnet (NethermindEth#6679) * Add Paris release spec class for completeness (NethermindEth#6633) * 0.0.0.0 to + --------- Co-authored-by: smartprogrammer <[email protected]> Co-authored-by: Marcin Sobczak <[email protected]> Co-authored-by: Ben Adams <[email protected]> Co-authored-by: Ruben Buniatyan <[email protected]> Co-authored-by: Ahmad Bitar <[email protected]> Co-authored-by: Kamil Chodoła <[email protected]> Co-authored-by: Lukasz Rozmej <[email protected]>
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs
. Remove if not applicable.Requires explanation in Release Notes
Cancun spec and config for mainnet added