Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow retrieving memory traces that are unconstrained in size #6649

Merged

Conversation

guidovranken
Copy link
Contributor

Changes

Adds a bool parameter to TraceMemory Slice(), which is true by default.
If true, an exception is thrown if the ReadOnlySpan<byte> to be returned from the function exceeds MemoryPadLimit.
If false, no size constraint is imposed on the return value. This is useful for retrieving the verbatim memory contents.

Types of changes

What types of changes does your code introduce?

  • New feature (a non-breaking change that adds functionality)

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Documentation

Requires documentation update

  • Yes
  • No

Requires explanation in Release Notes

  • Yes
  • No

@LukaszRozmej LukaszRozmej merged commit fcc242f into NethermindEth:master Feb 2, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants