Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate trie data via readonly refs #6626

Merged
merged 16 commits into from
Jan 29, 2024

Conversation

benaadams
Copy link
Member

Changes

  • Propagate trie data via readonly refs; allows return via register than via stack and the call stack can get quite deep navigating the trie

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but lets wait for more reviews

src/Nethermind/Nethermind.Trie/PatriciaTree.cs Outdated Show resolved Hide resolved
Type is checked then key and can throw if Leaf id no key set yet (parallel reads)
@benaadams benaadams merged commit 61ff62e into master Jan 29, 2024
67 checks passed
@benaadams benaadams deleted the Propagate-trie-data-via-readonly-refs branch January 29, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants