Hunting allocations 3 - introduce AccountStruct #6605
Conversation
LukaszRozmej
changed the title
# Conflicts: # src/Nethermind/Nethermind.State/StorageTree.cs
|
Nethermind.State/StateTree.cs(47,32): error CS0029: Cannot implicitly convert type 'System.ReadOnlySpan' to 'System.Span' |
| @@ -8,7 +8,7 @@ namespace Nethermind.Core | |||
| { | |||
| public class Account | |||
There was a problem hiding this comment.
There are places where we need to put it on heap, not sure if worth paying for boxing?
There was a problem hiding this comment.
But will try to move some usages to AccountStruct in next PR.
# Conflicts: # src/Nethermind/Nethermind.Serialization.Json/EthereumJsonSerializer.cs # src/Nethermind/Nethermind.Serialization.Rlp/AccountDecoder.cs # src/Nethermind/Nethermind.State/StateReader.cs # src/Nethermind/Nethermind.State/StateTree.cs
| public AccountStruct ToStruct() => new(Nonce, Balance, StorageRoot, CodeHash); | ||
| } | ||
|
|
||
| public readonly struct AccountStruct |
There was a problem hiding this comment.
This is a 128 bytes struct (0.125 kB); want to make sure are passing by in etc everywhere otherwise big copies (if low GC)
There was a problem hiding this comment.
How this comment ended? I see that in lot of places this is returned, no TryGet or ref semantics there? I'm asking as I'm applying these changes to Paprika and it looks that we're potentially copying to much here?
| @@ -162,7 +162,7 @@ public ResultWrapper<IEnumerable<Address>> eth_accounts() | |||
| return Task.FromResult(GetStateFailureResult<UInt256?>(header)); | |||
| } | |||
|
|
|||
| Account account = _stateReader.GetAccount(header!.StateRoot!, address); | |||
| AccountStruct? account = _stateReader.GetAccount(header!.StateRoot!, address); | |||
There was a problem hiding this comment.
Does it have to be nullable? Extra byte it adds is problematic on copy size (128 bytes -> 129 bytes)
better to init with empy code hash and empty storage has and pass that back if null?
There was a problem hiding this comment.
So been thinking about it, how to avoid copies to. Maybe the answer is something like:
bool TryGetAccount(root, address, ref AccountStruct account)
not sure if we could write directly to stack allocated by the calling method?
| } | ||
| else | ||
| { | ||
| storageRoot = rlpStream.DecodeValueKeccak()!.Value; |
There was a problem hiding this comment.
if for some reason DecodeValueKeccak() returns null, the underlaying value will probably be a zero-value struct(?)
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?