Reduce TxPool lock contention

[benaadams]

Changes

• HashCache, TxBroadcaster, TxDistinctSortedPool, BlobTxDistinctSortedPool are all thread safe collections so an overarching lock isn't required (compare changes ignoring whitespace; mostly indentation changes)

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

[LukaszRozmej]

Not analyzing it yet, but I think that lock potentially was to synchronize changes between multiple of those collections?

[benaadams]

Not analyzing it yet, but I think that lock potentially was to synchronize changes between multiple of those collections?

Is from 2 years ago Berlin upgrade before there were multiple collections; also I think they are either/or; txn is either in blob, regular or local but not in all

[benaadams]

Closing in favour of #6417