Implement default jwt-secret paths

[Zexuz]

Resolves #5948

Changes

• Remove default value for JsonRpc.JwtSecretFile
• implement default jwt-secret paths

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Notes on testing

Testing this is hard since it's all IO methods, but since it's now a more complex logic flow, maybe its worth it?

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

If yes, fill in the details here. Remove if not applicable.

Remarks

Should we update the docs and/or the release notes with the new files paths?

[Zexuz]

@MarekM25, any feedback?

[LukaszRozmej]

@MarekM25, any feedback?

@MarekM25 is currently on leave, @rubo and @deffrian could you take a look?

[LukaszRozmej]

Would be good to add some tests

[LukaszRozmej]

We also need to find better exception type here

[Zexuz]

Create a new custom Exception? Maybe one of these?

• NotFoundException
• NotSetException
• EnviormentVariableNotSet
• EnviormentVariableNotFound

[LukaszRozmej]

My candidates would be either InvalidOperationException or System.Configuration.ConfigurationException

[Zexuz]

Added some test, and broke out the the OS filePaths to a JwtSecretPathResolver to make testing easier. But the test cases for JwtAuthenticationTests are still huge. I don't see how to make them smaller since since it's all I/O stuff. Could refactor JwtAuthentication even more and break it up to two files, one for branch logic and on for the read/generate secrets. Since now the test cases need to setup the logic and test I/O.

[rubo]

Marking as draft for now until the spec finalizes. I'll back to this shortly.

@Zexuz Thanks for contributing.

[Zexuz]

Ping