Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for chiado gnosis testnet #4330

Merged
merged 14 commits into from
Aug 11, 2022
Merged

Add config for chiado gnosis testnet #4330

merged 14 commits into from
Aug 11, 2022

Conversation

jmederosalvarado
Copy link
Member

Changes:

  • Adds config for what will be gnosis first public testnet with merge support, named chiado

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe): Config

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests??

  • Yes
  • No

Copy link
Contributor

@MarekM25 MarekM25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add chainspec? What's about denver network?

@jmederosalvarado jmederosalvarado force-pushed the chiado_config branch 2 times, most recently from 732d812 to 7ab3d85 Compare August 2, 2022 15:11
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FastBlocks and AllowAuRaPrivateChains are probably to be removed?

src/Nethermind/Nethermind.Runner/configs/chiado.cfg Outdated Show resolved Hide resolved
src/Nethermind/Nethermind.Runner/configs/chiado.cfg Outdated Show resolved Hide resolved
@LukaszRozmej
Copy link
Member

Should they be added to some tests?

@MarekM25
Copy link
Contributor

MarekM25 commented Aug 4, 2022

@jmederosalvarado fix the runner tests ;)

"Enabled": true
},
"Aura": {
"TxPriorityContractAddress": "0x4100000000000000000000000000000000000000",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this contract to be specified here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied it from here. is it not being used or smth?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You tell me, all I know is that AuRa has many different contracts but only this one is specified here. I don't know the internals of Nethermind, nor which contracts have to be specified here and for what reason

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So priorities contract is used for potentially sorting transactions when creating blocks. Priorities can come from contract or local configuration. Priorities are optional. Not sure if you deployed this contract on denver. More information can be found here: #2300

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also. I see here that you have a contract deployed to this address in denver genesis. That's what is being used as TxPriorityContract in denver.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants