-
Notifications
You must be signed in to change notification settings - Fork 433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for chiado gnosis testnet #4330
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add chainspec? What's about denver network?
732d812
to
7ab3d85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FastBlocks and AllowAuRaPrivateChains are probably to be removed?
Should they be added to some tests? |
@jmederosalvarado fix the runner tests ;) |
"Enabled": true | ||
}, | ||
"Aura": { | ||
"TxPriorityContractAddress": "0x4100000000000000000000000000000000000000", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has this contract to be specified here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied it from here. is it not being used or smth?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You tell me, all I know is that AuRa has many different contracts but only this one is specified here. I don't know the internals of Nethermind, nor which contracts have to be specified here and for what reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So priorities contract is used for potentially sorting transactions when creating blocks. Priorities can come from contract or local configuration. Priorities are optional. Not sure if you deployed this contract on denver. More information can be found here: #2300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also. I see here that you have a contract deployed to this address in denver genesis. That's what is being used as TxPriorityContract
in denver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks!
49d5a15
to
6d1d359
Compare
Changes:
chiado
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyTesting
Requires testing
In case you checked yes, did you write tests??