Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare hash func in core/crypto #2352

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Declare hash func in core/crypto #2352

merged 1 commit into from
Dec 26, 2024

Conversation

weiihann
Copy link
Contributor

Removes hashFunc in core/trie and use the one newly declared in core/crypto

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 74.49%. Comparing base (4ba933f) to head (71a7fbf).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/trie/node.go 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2352      +/-   ##
==========================================
+ Coverage   74.42%   74.49%   +0.07%     
==========================================
  Files         110      110              
  Lines       11771    11771              
==========================================
+ Hits         8760     8769       +9     
+ Misses       2329     2324       -5     
+ Partials      682      678       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weiihann weiihann merged commit 4b9d3c2 into main Dec 26, 2024
13 checks passed
@weiihann weiihann deleted the weiihann/move-hashfn branch December 26, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants