-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nil hash validation #2296
base: main
Are you sure you want to change the base?
Add nil hash validation #2296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
==========================================
+ Coverage 75.42% 75.44% +0.01%
==========================================
Files 107 107
Lines 11406 11406
==========================================
+ Hits 8603 8605 +2
+ Misses 2150 2149 -1
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
7282cbe
to
0e92093
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ac9e228
to
fac578b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does using buf
in this PR is improving over not using buf?
Would adding buf means an extra dependency to compile Juno successfully or just for development? Should the use of buf
be documented somewhere as dependency?
Some questions, trying to understand the code base
Because we need to
This is for development only. |
Fix #2239
Continue #2290
This pull request introduces protobuf hash validation
This PR can be simplified with #2342