Remove transaction_hash from getBlockWithReceipts #2294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronGauntlets
force-pushed
the
IronGauntlets/fix-getBlockWithReceipts
branch
from
4b94597 to
d384bed
Compare
IronGauntlets
force-pushed
the
IronGauntlets/fix-getBlockWithReceipts
branch
from
d384bed to
2001756
Compare
wojciechos
approved these changes
Nov 28, 2024
`starknet_getBlockWithReceipts` was added in 0.7.x rpc spec, and its array of `transaction` doesn't contain `transaction_hash` instead its receipt contains the `transaction_hash`.
wojciechos
force-pushed
the
IronGauntlets/fix-getBlockWithReceipts
branch
from
2001756 to
5ceda46
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2294 +/- ##
==========================================
+ Coverage 75.41% 75.44% +0.03%
==========================================
Files 107 107
Lines 11404 11406 +2
==========================================
+ Hits 8600 8605 +5
+ Misses 2151 2149 -2
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
pnowosie
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
starknet_getBlockWithReceiptswas added in 0.7.x rpc spec and its array oftransactiondoesn't containtransaction_hashinstead it contains thetransaction_hash.