Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Makefile #2278

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Conversation

AnkushinDaniil
Copy link
Contributor

@AnkushinDaniil AnkushinDaniil commented Nov 23, 2024

This pull request includes several updates to the Makefile to improve clarity and functionality. The most important changes include adding descriptions to various targets, ensuring the linter is run conditionally, and adding a new target for running a node with specific configurations.

Enhancements to target descriptions and functionality:

  • Added descriptions to various targets to improve clarity, such as juno, generate, clean-testcache, test, test-cached, test-race, benchmarks, test-cover, install-deps, lint, tidy, format, clean, help, feedernode, node1, node2, node3, pathfinder, and test-fuzz. [1] [2] [3] [4] [5]

  • Modified the install-golangci-lint target to use command -v instead of which for checking if golangci-lint is installed.

  • Added a new target juno-cached with a description for cached Juno compilation.

  • Added --disable-l1-verification flag to node targets (node1, node2, node3, pathfinder) to disable L1 verification.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.43%. Comparing base (d9dcf6c) to head (eadad53).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
+ Coverage   75.41%   75.43%   +0.02%     
==========================================
  Files         107      107              
  Lines       11404    11404              
==========================================
+ Hits         8600     8603       +3     
+ Misses       2151     2149       -2     
+ Partials      653      652       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/add-disable-l1-verification-in-makefile branch from d81a3c9 to 1c4fdd1 Compare November 27, 2024 01:04
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Copy link
Contributor

@wojciechos wojciechos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/add-disable-l1-verification-in-makefile branch from c3104be to 8ae8750 Compare November 27, 2024 14:48
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AnkushinDaniil AnkushinDaniil force-pushed the daniil/add-disable-l1-verification-in-makefile branch 2 times, most recently from eb138fa to bfacc49 Compare November 29, 2024 08:44
@AnkushinDaniil AnkushinDaniil force-pushed the daniil/add-disable-l1-verification-in-makefile branch from 8b83bcd to eadad53 Compare November 29, 2024 08:49
@AnkushinDaniil AnkushinDaniil enabled auto-merge (squash) November 29, 2024 08:50
@AnkushinDaniil AnkushinDaniil removed the request for review from kirugan November 29, 2024 08:59
@AnkushinDaniil AnkushinDaniil enabled auto-merge (squash) November 29, 2024 09:00
@AnkushinDaniil AnkushinDaniil merged commit 93803e9 into main Nov 29, 2024
13 checks passed
@AnkushinDaniil AnkushinDaniil deleted the daniil/add-disable-l1-verification-in-makefile branch November 29, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants