-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Makefile #2278
Update Makefile #2278
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2278 +/- ##
==========================================
+ Coverage 75.41% 75.43% +0.02%
==========================================
Files 107 107
Lines 11404 11404
==========================================
+ Hits 8600 8603 +3
+ Misses 2151 2149 -2
+ Partials 653 652 -1 ☔ View full report in Codecov by Sentry. |
d81a3c9
to
1c4fdd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c3104be
to
8ae8750
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
eb138fa
to
bfacc49
Compare
…ication flag and adding commands to .PHONY
8b83bcd
to
eadad53
Compare
This pull request includes several updates to the
Makefile
to improve clarity and functionality. The most important changes include adding descriptions to various targets, ensuring the linter is run conditionally, and adding a new target for running a node with specific configurations.Enhancements to target descriptions and functionality:
Added descriptions to various targets to improve clarity, such as
juno
,generate
,clean-testcache
,test
,test-cached
,test-race
,benchmarks
,test-cover
,install-deps
,lint
,tidy
,format
,clean
,help
,feedernode
,node1
,node2
,node3
,pathfinder
, andtest-fuzz
. [1] [2] [3] [4] [5]Modified the
install-golangci-lint
target to usecommand -v
instead ofwhich
for checking ifgolangci-lint
is installed.Added a new target
juno-cached
with a description for cached Juno compilation.Added
--disable-l1-verification
flag to node targets (node1
,node2
,node3
,pathfinder
) to disable L1 verification.