Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket shutdown logic #2277

Merged
merged 10 commits into from
Dec 23, 2024
Merged

Websocket shutdown logic #2277

merged 10 commits into from
Dec 23, 2024

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Nov 20, 2024

No description provided.

@IronGauntlets IronGauntlets force-pushed the IronGauntlets/implement-subscribeEvents branch 2 times, most recently from 5a713f0 to bf93293 Compare November 20, 2024 11:52
Copy link
Contributor

@pnowosie pnowosie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just small concerns

jsonrpc/websocket.go Show resolved Hide resolved
jsonrpc/websocket_test.go Show resolved Hide resolved
rpc/events_test.go Show resolved Hide resolved
@IronGauntlets IronGauntlets force-pushed the IronGauntlets/implement-subscribeEvents branch 9 times, most recently from c218d68 to 301962d Compare November 26, 2024 12:47
Copy link
Contributor

@IronGauntlets IronGauntlets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please point the branch to main.

@kirugan kirugan changed the base branch from IronGauntlets/implement-subscribeEvents to main December 3, 2024 13:08
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (fce5078) to head (bffd12d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
node/http.go 70.00% 2 Missing and 1 partial ⚠️
jsonrpc/websocket.go 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
+ Coverage   74.37%   74.38%   +0.01%     
==========================================
  Files         110      110              
  Lines       11531    11546      +15     
==========================================
+ Hits         8576     8589      +13     
- Misses       2287     2289       +2     
  Partials      668      668              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnowosie pnowosie self-requested a review December 23, 2024 13:33
@kirugan kirugan merged commit 81262fd into main Dec 23, 2024
13 checks passed
@kirugan kirugan deleted the kirugan/ws-shutdown branch December 23, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants