-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websocket shutdown logic #2277
Websocket shutdown logic #2277
Conversation
5a713f0
to
bf93293
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Just small concerns
c218d68
to
301962d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please point the branch to main.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2277 +/- ##
==========================================
+ Coverage 74.37% 74.38% +0.01%
==========================================
Files 110 110
Lines 11531 11546 +15
==========================================
+ Hits 8576 8589 +13
- Misses 2287 2289 +2
Partials 668 668 ☔ View full report in Codecov by Sentry. |
No description provided.