Add subscribeEvents and subcriptionEvent #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
4 times, most recently
from
bf93293 to
26ad026
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2254 +/- ##
==========================================
- Coverage 75.44% 75.27% -0.17%
==========================================
Files 107 108 +1
Lines 11406 11541 +135
==========================================
+ Hits 8605 8688 +83
- Misses 2149 2186 +37
- Partials 652 667 +15 ☔ View full report in Codecov by Sentry. |
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
3 times, most recently
from
ecaaed4 to
6ad3741
Compare
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
5 times, most recently
from
c218d68 to
301962d
Compare
pnowosie
reviewed
Nov 28, 2024
kirugan
reviewed
Dec 3, 2024
kirugan
reviewed
Dec 3, 2024
kirugan
reviewed
Dec 3, 2024
The main reason for adding this interface is for testing as it is quite challenging to find events in a particular order.
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
from
301962d to
574e637
Compare
Using jsonrpc.Request for subscription response is misleading and by adding a separate struct for returning responses to subscription events is more appropriate
IronGauntlets
force-pushed
the
IronGauntlets/implement-subscribeEvents
branch
from
574e637 to
5cac638
Compare
kirugan
approved these changes
Dec 6, 2024
pnowosie
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.