Fix upper bound issue in CalculatePrefixSize
#2223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2223 +/- ##
==========================================
- Coverage 74.41% 74.36% -0.05%
==========================================
Files 109 109
Lines 11493 11519 +26
==========================================
+ Hits 8552 8566 +14
- Misses 2277 2285 +8
- Partials 664 668 +4 ☔ View full report in Codecov by Sentry. |
weiihann
force-pushed
the
weiihann/refactor-db-size
branch
2 times, most recently
from
9b0bd9c to
f6d9cef
Compare
|
This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
weiihann
force-pushed
the
weiihann/refactor-db-size
branch
from
1ecb18d to
d94df24
Compare
weiihann
changed the title
db size commandCalculatePrefixSize
wojciechos
approved these changes
Dec 17, 2024
weiihann
force-pushed
the
weiihann/refactor-db-size
branch
from
f34b203 to
e4b412b
Compare
This reverts commit e4b412b.
Co-authored-by: Pawel Nowosielski <[email protected]> Signed-off-by: Ng Wei Han <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the
db sizecommand to also check for leftover key-value pairs in the database. It also fixes an upper bound bug as theUpperBounditerator option is exclusive, not inclusive.