-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs for subcommands #2043
Add docs for subcommands #2043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2043 +/- ##
==========================================
+ Coverage 78.17% 78.22% +0.04%
==========================================
Files 101 101
Lines 9064 9064
==========================================
+ Hits 7086 7090 +4
+ Misses 1345 1343 -2
+ Partials 633 631 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'd add a reference to this documentation in Readme.md though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
- Restructured the subcommands section a bit
- Released a new version (0.12.0), so the changes are live once this is merged
I also agree with the suggestion of adding the subcommands to the README
@LordGhostX but in 0.12.0 juno version we didn't add this command, it's only in main. Do you think it might lead to confussion? |
@kirugan that's a good point. I thought the feature was live and was released in the last version (my bad) I'll make a follow-up PR to remove the 0.12.0 docs release, then we do it another time |
Closes #2041