New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Daniil/rust-linter-issues-fix #2030

Merged

derrix060 merged 19 commits into main from daniil/rust-linter-issues-fix

Aug 13, 2024

Contributor

AnkushinDaniil commented Aug 6, 2024

No description provided.

codecov bot commented Aug 6, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.16%. Comparing base (fe8a518) to head (77785b6).

Files	Patch %	Lines
starknet/compiler.go	87.50%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
- Coverage   78.24%   78.16%   -0.09%     
==========================================
  Files         101      101              
  Lines        9064     9062       -2     
==========================================
- Hits         7092     7083       -9     
- Misses       1342     1345       +3     
- Partials      630      634       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kirugan reviewed

View reviewed changes

starknet/rust/src/lib.rs Outdated Show resolved Hide resolved

kirugan reviewed

View reviewed changes

starknet/rust/src/lib.rs Outdated Show resolved Hide resolved

Contributor

kirugan commented Aug 7, 2024 •

edited

Loading

Please run make format after you make changes

kirugan reviewed

View reviewed changes

vm/rust/src/juno_state_reader.rs Show resolved Hide resolved

AnkushinDaniil requested a review from kirugan

August 8, 2024 10:06

kirugan approved these changes

View reviewed changes

wojciechos temporarily deployed to Development

August 8, 2024 13:54

— with

GitHub Actions Inactive

wojciechos had a problem deploying to Staging

August 8, 2024 13:56

— with

GitHub Actions Error

obasekiosa reviewed

View reviewed changes

starknet/rust/src/lib.rs Outdated Show resolved Hide resolved

obasekiosa reviewed

View reviewed changes

starknet/rust/src/lib.rs Outdated Show resolved Hide resolved

obasekiosa reviewed

View reviewed changes

vm/rust/src/lib.rs Outdated Show resolved Hide resolved

obasekiosa reviewed

View reviewed changes

vm/rust/src/lib.rs Show resolved Hide resolved

obasekiosa reviewed

View reviewed changes

Contributor

obasekiosa left a comment

It looks good, just a few questions and suggestions to sort out, then we can merge.

AnkushinDaniil requested review from kirugan and obasekiosa

August 9, 2024 12:48

AnkushinDaniil self-assigned this

AnkushinDaniil added go rust labels

obasekiosa reviewed

View reviewed changes

core/rust/src/lib.rs Outdated Show resolved Hide resolved

AnkushinDaniil requested a review from obasekiosa

August 9, 2024 13:16

obasekiosa approved these changes

View reviewed changes

Contributor

obasekiosa left a comment

outside some personal opinionated requests this lgtm

kirugan reviewed

View reviewed changes

starknet/rust/src/lib.rs Show resolved Hide resolved

AnkushinDaniil force-pushed the daniil/rust-linter-issues-fix branch from eb1efc0 to 5113fca Compare

August 12, 2024 12:45

derrix060 previously requested changes

View reviewed changes

Contributor

derrix060 left a comment

Please rebase your branch and only pick the commits you actually authored :)

There is also conflicts.

BTW it's easier to rebase your branch then merging main into yours when trying to keep up-to-date

AnkushinDaniil marked this pull request as draft

August 13, 2024 08:42

AnkushinDaniil marked this pull request as ready for review

August 13, 2024 09:48

AnkushinDaniil requested a review from kirugan

August 13, 2024 10:15

AnkushinDaniil force-pushed the daniil/rust-linter-issues-fix branch from b76ea38 to 5113fca Compare

August 13, 2024 10:28


          slices, for loop copy, min/max update

52c556c

AnkushinDaniil added 17 commits

August 13, 2024 13:51


          append revert

0204ef1


          typo fixed

49ec4d8


          linker fixed

e294f42


          Update versioned constants for Starknet

2d2545b


          Refactor class_hash assignment in cairoVMCall function

03c39d9


          Remove unused code in JunoStateReader

fcbe4d7


          chore: Refactor class_info_from_json_str function in JunoStateReader.rs

9c0e55b


          Refactor extern "C" functions in lib.rs

2dfc360


          Update std::ffi import in versioned_constants.rs

5abe2fc


          Refactor extern "C" functions in lib.rs

234e82c


          Refactor extern "C" functions in lib.rs

6806ecd


          Refactor extern "C" functions in lib.rs

2a5a1ec


          Refactor error handling in compileSierraToCasm function

8d04664


          Add err handling

50fe209


          Refactor error handling in compileSierraToCasm function

474f0d5


          Refactor get_versioned_constants function in lib.rs

b535aec


          Refactor error handling in compileSierraToCasm function

eaa9261

AnkushinDaniil force-pushed the daniil/rust-linter-issues-fix branch from 5113fca to eaa9261 Compare

August 13, 2024 11:13


          Revert diff

77785b6

derrix060 dismissed their stale review

August 13, 2024 12:00

no conflicts anymore

derrix060 merged commit 15e4323 into main

10 checks passed

derrix060 deleted the daniil/rust-linter-issues-fix branch

August 13, 2024 12:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go rust