Update snapshot link in README #2007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2007 +/- ##
==========================================
- Coverage 75.47% 75.45% -0.03%
==========================================
Files 100 100
Lines 8983 8983
==========================================
- Hits 6780 6778 -2
- Misses 1601 1602 +1
- Partials 602 603 +1 ☔ View full report in Codecov by Sentry. |
rianhughes
approved these changes
Aug 2, 2024
derrix060
force-pushed
the
mario/update-snapshot-link-in-readme
branch
2 times, most recently
from
6851e8e to
0935da5
Compare
Have the link pointing to the latest available snapshot. In order for this to work, I had to remove the size and what's the latest block from the table, so we won't have to manually update this information everytime. I also included a way to know how big the snapshot is via script, so this information will always be up-to-date by the time someone runs the command
derrix060
force-pushed
the
mario/update-snapshot-link-in-readme
branch
from
0935da5 to
296cb02
Compare
kirugan
reviewed
Aug 2, 2024
kirugan
approved these changes
Aug 2, 2024
|
I guess we could also update our docs with those links: https://github.com/NethermindEth/juno/blob/main/docs/docs/snapshots.md |
|
Good idea -> #2013 |
AnkushinDaniil
pushed a commit
that referenced
this pull request
Aug 12, 2024
Have the link pointing to the latest available snapshot. In order for this to work, I had to remove the size and what's the latest block from the table, so we won't have to manually update this information everytime. I also included a way to know how big the snapshot is via script, so this information will always be up-to-date by the time someone runs the command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have the link pointing to the latest available snapshot.
In order for this to work, I had to remove the size and what's the latest block from the table, so we won't have to manually update this information everytime.
I also included a way to know how big the snapshot is via script, so this information will always be up-to-date by the time someone runs the command