Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 0.13.2 (hashes) #1964

Merged
merged 31 commits into from
Jul 30, 2024
Merged

Update 0.13.2 (hashes) #1964

merged 31 commits into from
Jul 30, 2024

Conversation

kirugan
Copy link
Contributor

@kirugan kirugan commented Jul 23, 2024

No description provided.

kirugan added 15 commits June 19, 2024 15:29
@kirugan kirugan force-pushed the kirugan/update-0.13.2-hashes branch 2 times, most recently from 737d11b to fb2aa5e Compare July 23, 2024 17:30
@kirugan kirugan force-pushed the kirugan/update-0.13.2-hashes branch from 3b9e643 to 9d5c4e9 Compare July 29, 2024 09:24
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.36059% with 34 lines in your changes missing coverage. Please review.

Project coverage is 75.50%. Comparing base (62b354d) to head (87506ca).

Files Patch % Lines
core/receipt.go 71.05% 7 Missing and 4 partials ⚠️
core/transaction.go 84.37% 5 Missing and 5 partials ⚠️
core/block.go 90.24% 4 Missing and 4 partials ⚠️
core/trie/trie.go 66.66% 1 Missing and 1 partial ⚠️
node/node.go 50.00% 1 Missing and 1 partial ⚠️
core/state_update.go 98.38% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   75.22%   75.50%   +0.27%     
==========================================
  Files          99      100       +1     
  Lines        8760     8968     +208     
==========================================
+ Hits         6590     6771     +181     
- Misses       1586     1598      +12     
- Partials      584      599      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kirugan
kirugan commented Jul 29, 2024
View reviewed changes
blockchain/blockchain.go Outdated Show resolved Hide resolved
@kirugan kirugan force-pushed the kirugan/update-0.13.2-hashes branch from 2138dd4 to ac1276a Compare July 29, 2024 22:17
@kirugan kirugan force-pushed the kirugan/update-0.13.2-hashes branch from ac1276a to 7418da1 Compare July 29, 2024 22:18
rianhughes
rianhughes reviewed Jul 30, 2024
View reviewed changes
core/transaction.go Outdated Show resolved Hide resolved
rianhughes
rianhughes reviewed Jul 30, 2024
View reviewed changes
core/block_test.go Outdated Show resolved Hide resolved
@IronGauntlets IronGauntlets force-pushed the kirugan/update-0.13.2-hashes branch from 808a669 to 278a97e Compare July 30, 2024 14:59
@IronGauntlets IronGauntlets marked this pull request as ready for review July 30, 2024 16:53
kirugan
kirugan commented Jul 30, 2024
View reviewed changes
core/block_test.go Outdated Show resolved Hide resolved
@kirugan kirugan merged commit ca76d85 into main Jul 30, 2024
17 of 18 checks passed
@kirugan kirugan deleted the kirugan/update-0.13.2-hashes branch July 30, 2024 21:34
kirugan added a commit that referenced this pull request Jul 31, 2024
@kirugan @IronGauntlets
Update hashing functions for 0.13.2 (#1964)
df48ed9 
Co-authored-by: IronGauntlets <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rianhughes rianhughes rianhughes approved these changes

@IronGauntlets IronGauntlets IronGauntlets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kirugan @IronGauntlets @rianhughes @wojciechos