Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emit events #1721

Closed
wants to merge 1 commit into from
Closed

Conversation

aminsato
Copy link
Contributor

I implement emitting events on the remote DB that related to the issue #1414

@kirugan kirugan force-pushed the aminsato/emit_events branch from 46feee3 to cf28527 Compare August 14, 2024 20:48
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.21%. Comparing base (dc46ab3) to head (cf28527).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
db/remote/db.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1721      +/-   ##
==========================================
+ Coverage   78.11%   78.21%   +0.09%     
==========================================
  Files         101      101              
  Lines        9062     9064       +2     
==========================================
+ Hits         7079     7089      +10     
+ Misses       1348     1345       -3     
+ Partials      635      630       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kirugan
Copy link
Contributor

kirugan commented Aug 30, 2024

Closing the PR since all neccesery logic was implemented in #2088

@kirugan kirugan closed this Aug 30, 2024
@aminsato aminsato deleted the aminsato/emit_events branch August 30, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants