Move latest block fetch out of store callback #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
requested review from
a team and
IronGauntlets
and removed request for
a team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1253 +/- ##
==========================================
- Coverage 73.79% 73.78% -0.01%
==========================================
Files 70 70
Lines 7608 7633 +25
==========================================
+ Hits 5614 5632 +18
- Misses 1535 1540 +5
- Partials 459 461 +2
☔ View full report in Codecov by Sentry. |
omerfirmak
force-pushed
the
omerfirmak/latest-poll
branch
from
7ddb89b to
f9b6ff9
Compare
joshklop
reviewed
Sep 19, 2023
store callback is on the hot path of sync process, a network request is not suitable to be here since it blocks the entire sync process for arbitrarily long
omerfirmak
force-pushed
the
omerfirmak/latest-poll
branch
from
f9b6ff9 to
3b6b771
Compare
joshklop
approved these changes
Sep 19, 2023
|
This is a general comment about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store callback is on the hot path of sync process, a network request is not suitable to be here since it blocks the entire sync process for arbitrarily long