Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Horus version to output #46

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Conversation

ElijahVlasov
Copy link
Contributor

No description provided.

Copy link
Contributor

@langfield langfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proposed bumping the minor version on every PR in slack, and it seemed Julian thinks this is a good idea.

How do you feel about starting this practice here?

I also wonder if it would be better to make the merge base flattening. This is up to your discretion, I do not know what would make more sense.

@ElijahVlasov
Copy link
Contributor Author

ElijahVlasov commented Jan 17, 2023

I proposed bumping the minor version on every PR in slack, and it seemed Julian thinks this is a good idea.

That's a great idea!

How do you feel about starting this practice here?

Will do.

I also wonder if it would be better to make the merge base flattening. This is up to your discretion, I do not know what would make more sense.

I want to put off merging flattening for now. Need to test other features introduced so far.

Copy link
Contributor

@langfield langfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ElijahVlasov ElijahVlasov merged commit 5c5e04b into master Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants