Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution API alignment #88

Merged
merged 40 commits into from
Jun 7, 2023
Merged

Execution API alignment #88

merged 40 commits into from
Jun 7, 2023

Conversation

Scooletz
Copy link
Contributor

@Scooletz Scooletz commented May 22, 2023

This PR introduces a new functionality that is aligned to how the Execution Client works. It embraces the notion of NewPayload and ForkChoiceUpdate by introducing a possibility of tracking multiple chains at the same time. Once FCU publishes the final hash, it's pushed down to the storage with all the preceding blocks. This means that for all head changes, the change is done without involvement of the underlying database.

The PR includes an updated design.md document that covers the changes.

Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not structs?

@Scooletz
Copy link
Contributor Author

Why not structs?

I don't understand the comment @LukaszRozmej. This is in the making and I already pivoted to use the same pages as in PagedDb. Updated the description to have it aligned. I don't want to multiply entities here so will reuse for now.

@Scooletz Scooletz mentioned this pull request May 31, 2023
10 tasks
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Code Coverage

Package Line Rate Branch Rate Health
Paprika 84% 73%
Summary 84% (1489 / 1766) 73% (354 / 486)

Minimum allowed line rate is 75%

@Scooletz Scooletz marked this pull request as ready for review June 7, 2023 09:56
@Scooletz Scooletz merged commit 8c4bb39 into main Jun 7, 2023
@Scooletz Scooletz deleted the execution-api-alignment branch June 7, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants