Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merkle construct introduced #113

Merged
merged 47 commits into from
Aug 9, 2023
Merged

Merkle construct introduced #113

merged 47 commits into from
Aug 9, 2023

Conversation

Scooletz
Copy link
Contributor

@Scooletz Scooletz commented Jul 24, 2023

This PR introduces the ComputeMerkleBehavior as a plugin that is run before the block commitment. This allows to track the dirty parts of the tree so that later, on the basis of the dirty flag, the root can be computed. This work is done in a tree type agnostic manner, but it assumes State only. The storage should be based on this.

The memoization of intermediate Keccaks and the calculation algorithm is not a part of this PR.

@Scooletz Scooletz added the ethereum An Ethereum specific work item that requires a good understanding of Eth label Jul 24, 2023
@Scooletz Scooletz mentioned this pull request Jul 24, 2023
10 tasks
@Scooletz Scooletz changed the title Dirty tracking Merkle Merkle construct introduced Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Code Coverage

Package Line Rate Branch Rate Health
Paprika 88% 78%
Summary 88% (2216 / 2525) 78% (574 / 740)

Minimum allowed line rate is 75%

@Scooletz Scooletz marked this pull request as ready for review August 9, 2023 10:34
@Scooletz Scooletz merged commit e26c8b0 into main Aug 9, 2023
2 checks passed
@Scooletz Scooletz deleted the merkle-dirty branch August 9, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ethereum An Ethereum specific work item that requires a good understanding of Eth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant