Feature/tree scale #346
Merged
Feature/tree scale #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersatile with units
- Unit character is removed from input string
bozmir
approved these changes
Dec 12, 2024
| double.TryParse(position.zField.Text, out var z); | ||
| var numberFormat = new NumberFormatInfo | ||
| { | ||
| NumberDecimalSeparator = "." |
There was a problem hiding this comment.
strings die vaker gebruikt gaan worden altijd cachen. dit is veel memory allocatie, dus bv. NumberDecimalSeparator = defaultNumberSeperator;
| float.TryParse(rotation.zField.Text, out var z); | ||
| var numberFormat = new NumberFormatInfo | ||
| { | ||
| NumberDecimalSeparator = "." |
| float.TryParse(scale.zField.Text.Replace(percentageCharacter, ""), out var z); | ||
| var numberFormat = new NumberFormatInfo | ||
| { | ||
| NumberDecimalSeparator = "." |
|
|
||
| TransformPropertyData.LocalScale = new Vector3(x / 100.0f, y / 100.0f, z / 100.0f); | ||
| TransformPropertyData.LocalScale = new Vector3(x / scaleMultiplier, y / scaleMultiplier, z / scaleMultiplier); |
There was a problem hiding this comment.
misschien omdat ik te weinig kennis heb van dit onderdeel maar met een multiplier verwacht ik een * operator, moet de input waarde zijn inverse zijn?
| scale.xField.SetTextWithoutNotify($"{xPercentage.ToString("0", CultureInfo.InvariantCulture)}{percentageCharacter}"); | ||
| scale.yField.SetTextWithoutNotify($"{yPercentage.ToString("0", CultureInfo.InvariantCulture)}{percentageCharacter}"); | ||
| scale.zField.SetTextWithoutNotify($"{zPercentage.ToString("0", CultureInfo.InvariantCulture)}{percentageCharacter}"); | ||
| return format; |
There was a problem hiding this comment.
string defaultZero = "0";
string defaultZeroSeperator = "0.";
en
format += defaultZero;
nog beter een stringbuilder maar dat is in dit geval overkill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cdn-dev-ams-3da.azureedge.net/autobuild/feature/tree-scale/345478263/