Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: remove workaround for macOS issues #769

Merged
merged 1 commit into from
Dec 17, 2020
Merged

github: remove workaround for macOS issues #769

merged 1 commit into from
Dec 17, 2020

Conversation

1480c1
Copy link
Contributor

@1480c1 1480c1 commented Dec 16, 2020

Fixes the current macOS issues

@1480c1
Copy link
Contributor Author

1480c1 commented Dec 16, 2020

I think macOS is just cursed at this point https://github.com/1480c1/vmaf/runs/1561670926 https://github.com/Netflix/vmaf/runs/1561696026 same commit

@kylophone
Copy link
Collaborator

I think macOS is just cursed at this point https://github.com/1480c1/vmaf/runs/1561670926 https://github.com/Netflix/vmaf/runs/1561696026 same commit

Yeah, those extra brew commands were added awhile back to work around a different brew issue. Should I merge this as-is, or is more work needed?

@1480c1
Copy link
Contributor Author

1480c1 commented Dec 16, 2020

I think macOS is just cursed at this point https://github.com/1480c1/vmaf/runs/1561670926 https://github.com/Netflix/vmaf/runs/1561696026 same commit

Yeah, those extra brew commands were added awhile back to work around a different brew issue. Should I merge this as-is, or is more work needed?

I think more work/info is needed either on brew's side or github, so don't merge this one yet

@1480c1 1480c1 marked this pull request as draft December 16, 2020 19:41
@1480c1
Copy link
Contributor Author

1480c1 commented Dec 16, 2020

actions/runner-images#2248 (comment) it seems maybe a max of 24 hours now?

@1480c1
github: remove workaround for macOS
ef1b4d0 
Signed-off-by: Christopher Degawa <[email protected]>
@1480c1 1480c1 changed the title github: don't uninstall non-existant formula github: remove workaround for macOS issues Dec 17, 2020
@1480c1 1480c1 marked this pull request as ready for review December 17, 2020 17:40
@1480c1
Copy link
Contributor Author

1480c1 commented Dec 17, 2020

@kylophone seems the issues were resolved in the latest image

@kylophone kylophone merged commit b136268 into Netflix:master Dec 17, 2020
@kylophone
Copy link
Collaborator

Thank you, merged.

@1480c1 1480c1 deleted the github/ffmpeg/macos branch December 17, 2020 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1480c1 @kylophone