Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use getfullargspec from inspect module for py3 #55

Merged
merged 1 commit into from
Jan 22, 2020
Merged

Use getfullargspec from inspect module for py3 #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions pygenie/jobs/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@

logger = logging.getLogger('com.netflix.genie.jobs.utils')

try:
getargspec = inspect.getfullargspec
except AttributeError:
# py2 compatible
getargspec = inspect.getargspec


REPR_APPEND_MODES = {
'append',
'insert'
Expand Down Expand Up @@ -121,7 +128,7 @@ def wrapper(*args, **kwargs):

assert len(args) == 2, 'incorrect arguments to {}()'.format(func.__name__)

attr_name = inspect.getargspec(func).args[1]
attr_name = getargspec(func).args[1]
self = args[0]
value = args[1]

Expand Down Expand Up @@ -156,8 +163,7 @@ def wrapper(*args, **kwargs):
"""Set arg to object's attribute as a string."""

assert len(args) == 2, 'incorrect arguments to {}()'.format(func.__name__)

attr_name = inspect.getargspec(func).args[1]
attr_name = getargspec(func).args[1]
self = args[0]
value = args[1]

Expand Down