-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babel 7 support #104
Babel 7 support #104
Conversation
b02df02
to
ab1141a
Compare
import alias from 'rollup-plugin-alias'; | ||
import babel from 'rollup-plugin-babel'; | ||
import { terser } from 'rollup-plugin-terser'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
); | ||
expect( | ||
await serializeRequestBody( | ||
new File(['file'], 'file.txt', { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readAsDataURL function is supported, but the mediatype in Chrome depends on entry name extension, mediatype in IE is always empty (which is the same as text-plain according the specification), the mediatype in Firefox is always application/octet-stream. For example, if the content is abcdefg then Firefox returns data:application/octet-stream;base64,YWJjZGVmZw==, IE returns data:;base64,YWJjZGVmZw==, Chrome returns data:;base64,YWJjZGVmZw==.
Seems how the type is negotiated when not supplied is a browser quirk. In Chrome 68 if the type is ''
it would not default to application/octet-stream
- now it does... like Firefox.
c8e7a73
to
2d7f4e6
Compare
"testem": "^2.10.0" | ||
}, | ||
"dependencies": { | ||
"@babel/runtime-corejs2": "^7.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
intentional runtime dep for polly to work in node 6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasonmit I think this should go in devDependencies
No description provided.