-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the github plugin dependency to start bot #35
Conversation
I'll try to take a look at this later this week. |
I'll need to see how this works with regards to plugins that make use of GitHub. For example, I'll need to see how the Travis CI plugin would work with this change. |
@goduncan : Been busy lately -- didn't forget about this. Can you resolve the conflicts? |
No worries. I haven't had time to test if the Travis plugin works as before with the changed but the bot starts with it enabled. |
Hello. Do you still think it's likely that you will be merge this? |
Hi @goduncan ! I will look at it today. I PROMISE! |
You will need to make a change here: https://github.com/goduncan/hubcommander/blob/develop/command_plugins/travis_ci/plugin.py#L72 GitHub is a dependency for Travis CI. I'll come up with the sample fix. |
@goduncan The PR looks good. I will submit a follow-up PR with the additional fixes for Travis CI. |
command_plugin
directory allowing the bot to be run with only a Slack Token.