pekko: update client helper to support flow API #1677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update PekkoHttpClient to support `superPool` more commonly used with streams. Also hooks in retry logic to make it work with the logger consistently and support throttling. Pekko's internal pool retries only happen if the request fails with an exception. This also provides some more flexiblity with the retry decision so it may be used for requests that are not clearly idempotent based on the HTTP spec, but maybe ok to retry for a given use-case.
manolama
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update PekkoHttpClient to support
superPoolmore commonly used with streams. Also hooks in retry logic to make it work with the logger consistently and support throttling. Pekko's internal pool retries only happen if the request fails with an exception. This also provides some more flexiblity with the retry decision so it may be used for requests that are not clearly idempotent based on the HTTP spec, but maybe ok to retry for a given use-case.