Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwc: use SortedTagMap for data points #1488

Merged
merged 2 commits into from
Nov 12, 2022

Conversation

brharrington
Copy link
Contributor

The main advantage is that for eval it can just quickly copy into an array without all the hashing and extra space in the hash array to avoid collisions.

Note, this change is safe to roll out as long as the lwcapi service is pushed first.

The main advantage is that for eval it can just quickly
copy into an array without all the hashing and extra
space in the hash array to avoid collisions.

Note, this change is safe to roll out as long as the
lwcapi service is pushed first.
@brharrington brharrington added this to the 1.7.0 milestone Nov 12, 2022
Copy link
Contributor

@manolama manolama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine assuming we update everything that generates LwcMessages first.

@brharrington brharrington merged commit d68272f into Netflix:main Nov 12, 2022
@brharrington brharrington deleted the lwc-sorted branch November 12, 2022 00:32
manolama pushed a commit to manolama/atlas that referenced this pull request May 22, 2024
The main advantage is that for eval it can just quickly
copy into an array without all the hashing and extra
space in the hash array to avoid collisions.

Note, this change is safe to roll out as long as the
lwcapi service is pushed first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants