Improve handling of error messages on decoding errors. #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that all code paths that can throw a type error will log it properly and with as much information as possible.
kilink
approved these changes
Sep 25, 2024
akang31
reviewed
Sep 25, 2024
| @@ -130,7 +131,7 @@ public <T> Property<T> asType(Function<String, T> mapper, String defaultValue) { | |||
| try { | |||
| return mapper.apply(value); | |||
| } catch (Exception e) { | |||
| LOG.warn("Invalid value '{}' for property '{}'", propName, value); | |||
| LOG.error("Invalid value '{}' for property '{}'. Will return the default instead.", propName, value); | |||
There was a problem hiding this comment.
I think due to the implementation of the above asType method, this just ends up returning null (this is what we observed in https://netflix.slack.com/archives/C141EJAJU/p1723751704356699)
There was a problem hiding this comment.
Yeah, I saw that. It's the same as in the get() method. I'll delve into fixing those two and any others I find in a separate PR, I want that one to be as clean as I can so it can be called out in the release notes and also it's easy to pinpoint if/when people complain about a behavior change.
There was a problem hiding this comment.
OK LGTM if this is assuming we are changing to that behavior, though this error message is technically a little off until we get to that point
akang31
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that all code paths that can throw a type error will log it properly and with as much information as possible.