Update RAD.java to account for null isForceDiff #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor for the class RAD expects an optional argument for the class member isForceDiff which is a Boolean wrapper (line 46). If the argument is not passed in, the member stays null.
line 46: this.isForceDiff = Boolean.parseBoolean(parameters[3]);
This throws an NPE at line 181 where the code checks if (this.isForceDiff).
line 181: } else if (this.isForceDiff) {
To overcome this, isForceDiff has to be passed at least as False.
Fix: The code should check for null at line 181 or make isForceDiff primitive for it to default to false.
Raised an issue at Netflix#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor for the class RAD expects an optional argument for the class member isForceDiff which is a Boolean wrapper (line 46). If the argument is not passed in, the member stays null.
line 46: this.isForceDiff = Boolean.parseBoolean(parameters[3]);
This throws an NPE at line 181 where the code checks if (this.isForceDiff).
line 181: } else if (this.isForceDiff) {
To overcome this, isForceDiff has to be passed at least as False.
Fix: The code should check for null at line 181 or make isForceDiff primitive for it to default to false.
Raised an issue at #11