Changes to hook API to make it more Observable-friendly #683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 16, 2015 14:11
…trixObservableCommand. * Deprecated some methods in HystrixCommandExecutionHook and added others * Reorganized calling patterns of hook methods in AbstractCommand to make them more cleanly divisible
…est to share code * Also changed how hook tests are written to be less verbose
|
NetflixOSS » Hystrix » Hystrix-pull-requests #45 SUCCESS |
mattrjacobs
added a commit
that referenced
this pull request
Feb 18, 2015
Changes to hook API to make it more Observable-friendly
This was referenced Feb 18, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #682 and #600 . See #682 for detail on new API.
Since this affects both
HystrixCommandandHystrixObservableCommandand had a large impact on unit tests, I took some time to share code between the two. This partially addresses #581