Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making provided scope transtive #66

Merged
merged 1 commit into from
Jan 2, 2013
Merged

Conversation

quidryan
Copy link
Contributor

@quidryan quidryan commented Jan 2, 2013

Internally junit:junit:4.10 actually points to junit:junit-dep:4.10. And that single hop is where things were breaking. This commit will fix all transitive issues related to the provided scope.

I'd actually recommend changing all junit:junit references to junit:junit-dep. The problem with junit:junit is that it bundles hamcrest in it, so you're limited in your ability to include a better hamcrest matching libraries since junit pollutes the classpath.

benjchristensen added a commit that referenced this pull request Jan 2, 2013
Making provided scope transtive
@benjchristensen benjchristensen merged commit 8852525 into Netflix:master Jan 2, 2013
@benjchristensen
Copy link
Contributor

Thanks Justin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants