getRollingCountThreadsExecuted() always returns 0 in master #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hystrix-pull-requests #167 FAILURE |
…rns 0 in 1.4.x - failing test case
nurkiewicz
force-pushed
the
getRollingCountThreadsExecuted-bug
branch
from
9f977ba
to
3b30e33
Compare
|
Hystrix-pull-requests #168 ABORTED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HystrixThreadPoolMetrics.getRollingCountThreadsExecuted()always returns0inmaster(1.4.x) rather than true count. This was working in 1.3.x.This pull request is just a failing test case, not a fix. Second test fails in
masterbut passes in1.3.x. I addedHystrixThreadPoolMetricsTest.resetAll()to public API in order to properly clean up after test.