Fix for Semaphore vs Thread Isolation Bug #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `Immediate` so that we don't add scheduling overhead unless needed. - Reuse the Hystrix thread if it is there. The computation of the callback can be part of the Hystrix thread. - No one using Hystrix+Observable should be doing anything blocking on those callbacks.
- only SEMAPHORE reject if SEMAPHORE isolation is being used - unit test to assert that THREAD and SEMAPHORE isolation reject independently of each other
|
Hystrix-pull-requests #109 FAILURE |
|
The build failure was something to do with javadoc ... going to stop javadocs from being generated as they are not needed and irritating in how fragile they are. |
benjchristensen
added a commit
that referenced
this pull request
Apr 1, 2014
…ation Fix for Semaphore vs Thread Isolation Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #232 where SEMAPHORE and THREAD rejection rules were both being applied at the same time after the
HystrixObservableCommandrefactor.