Upgrade to metrics library v3.0.1

[rore]

These are the changes required to upgrade the metrics library to the new version (3.0.1).
The new metrics version includes changes in namespace and interfaces.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #55 FAILURE
Looks like there's a problem with this pull request

[benjchristensen]

Is this a backwards compatible change, or do we need a separate module?

[benjchristensen]

Thanks by the way for contributing!

[rore]

Ah, you are right. It's not backward compatible.
Since the new metrics version is on another namespace there's no problem supporting both. My changes just needs to be duplicated to other classes and the existing ones can remain.
I can get to it in the next couple of days.

[benjchristensen]

Thanks.

[rore]

Done. The previous code is unchanged, I added the new classes using the v3 metrics version under a new namespace.

[cloudbees-pull-request-builder]

Hystrix-pull-requests #57 FAILURE
Looks like there's a problem with this pull request

[benjchristensen]

Is it okay to have both versions imported in the same project? Are they namespaced separately?

Or do we need a completely new submodule 'hystrix-yammer-metrics3-publisher'?

And what is the "official" GroupID since there is both 'com.yammer' and 'com.codahale'. Version 2 was 'com.yammer', this adds version 3 using 'com.codahale'. Both are available on Maven Central: http://search.maven.org/#search%7Cga%7C1%7Cmetrics-core

[rore]

In version 3 they changed the namespace from com.yammer to com.codahale to allow side-by-side, so there is no problem with having them both in the same project. No need for a separate sub-module.

[benjchristensen]

But that does mean we are forcing people to pull in both dependencies, version 2 and version 3.

[rore]

You can exclude the one you don't need in your pom so it won't bring it.
Not good enough?

On Tue, Nov 12, 2013 at 9:41 PM, Ben Christensen
[email protected]:

In hystrix-contrib/hystrix-yammer-metrics-publisher/build.gradle:

@@ -5,6 +5,7 @@ apply plugin: 'idea'
dependencies {
compile project(':hystrix-core')
compile 'com.yammer.metrics:metrics-core:2.2.0'

• compile 'com.codahale.metrics:metrics-core:3.0.1'

But that does mean we are forcing people to pull in both dependencies,
version 2 and version 3.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/193/files#r7604061
.

[benjchristensen]

That's rather awkward to require people to manually exclude libraries they don't want to pull in.

Especially since it's a new namespace, how about a new module 'hystrix-codahale-metrics3-publisher'?

[rore]

Sounds decent :-)

On Tue, Nov 12, 2013 at 9:59 PM, Ben Christensen
[email protected]:

In hystrix-contrib/hystrix-yammer-metrics-publisher/build.gradle:

@@ -5,6 +5,7 @@ apply plugin: 'idea'
dependencies {
compile project(':hystrix-core')
compile 'com.yammer.metrics:metrics-core:2.2.0'

• compile 'com.codahale.metrics:metrics-core:3.0.1'

That's rather awkward to require people to manually exclude libraries they
don't want to pull in.

Especially since it's a new namespace, how about a new module
'hystrix-codahale-metrics3-publisher'?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/193/files#r7604748
.

[caps]

Hey guys, this is something I'm interested in using. Is there anything I can do to help out? e.g. Create the new module 'hystrix-codahale-metrics3-publisher'?

[cloudbees-pull-request-builder]

Hystrix-pull-requests #61 FAILURE
Looks like there's a problem with this pull request

[cloudbees-pull-request-builder]

Hystrix-pull-requests #62 FAILURE
Looks like there's a problem with this pull request

[rore]

Sorry for the delay, was a bit busy.
I moved the metrics3 changed code into a separate project.

[caps]

No worries! Let me know if there is anything I can do to assist.

[benjchristensen]

I believe #199 achieves this.