BugFix: queue() BadRequestException Handling on Cached Response #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HystrixBadRequestException was being thrown directly instead of via the returned Future when a cached response was retrieved. See included unit test for details.
|
@daveray Can you review this please to validate it fixes the issue you reported? This is definitely an edge case. |
|
Hystrix-pull-requests #50 SUCCESS |
| } | ||
|
|
||
| try { | ||
| new BadRequestCommand(circuitBreaker, ExecutionIsolationStrategy.THREAD).queue().get(); |
There was a problem hiding this comment.
I'm guessing that because you're explicitly catching ExecutionException below that that's how you're sure the exception is coming from get() and not queue()?
There was a problem hiding this comment.
Yes, and if it's not an ExecutionException it will end up in the next Exception catch block and fail the test.
benjchristensen
added a commit
that referenced
this pull request
Sep 27, 2013
…ption BugFix: queue() BadRequestException Handling on Cached Response
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HystrixBadRequestException was being thrown directly instead of via the returned Future when a cached response was retrieved.
See included unit test for details.