Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadLocal memory leak in HystrixRequestContext #320

Closed
jrummler opened this issue Sep 25, 2014 · 2 comments
Closed

ThreadLocal memory leak in HystrixRequestContext #320

jrummler opened this issue Sep 25, 2014 · 2 comments

Comments

@jrummler
Copy link

When shutting down Tomcat with registered HystrixRequestContextServletFilter there seems to be a memory leak detected when shutting the context down:

2014-09-25 16:17:47,774 SEVERE -  - org.apache.catalina.loader.WebappClassLoader checkThreadLocalMapForLeaks - The web application [/someWebApp] created a ThreadLocal with key of type [java.lang.ThreadLocal] (value [java.lang.ThreadLocal@5e99af68]) and a value of type [com.netflix.hystrix.strategy.concurrency.HystrixRequestContext] (value[com.netflix.hystrix.strategy.concurrency.HystrixRequestContext@2685b544]) but failed to remove it when the web application was stopped. Threads are going to be renewed over time to try and avoid a probable memory leak.

However, I call Hystrix.reset() when shutting down - is there anything I can do but deactivate memory leak checks on Tomcat shutdown?

Thank you!
Jens

@benjchristensen
Copy link
Contributor

I don't know. We never shut apps down gracefully, we just kill the process.

@benjchristensen
Copy link
Contributor

Is there anything further to do on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants