Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThreadLocal memory leak in HystrixRequestContext #1202

Closed
petehannam opened this issue May 10, 2016 · 2 comments
Closed

ThreadLocal memory leak in HystrixRequestContext #1202

petehannam opened this issue May 10, 2016 · 2 comments

Comments

@petehannam
Copy link

petehannam commented May 10, 2016

This essentially reopens #320.

We (currently) use Tomcat, so are getting Hystrix memory leak errors when it's shutdown or we redeploy.

The issue is that in the shutdown() method, it doesn't clear out the requestVariables field. (I'd be happy to submit a PR, but couldn't see a contributor's guide, so wasn't sure on your process).

For anyone else who's been looking at this, we also had to call Schedulers.shutdown(); in our ServletContextListener, as RxJava holds its own threadpool.

@mattrjacobs
Copy link
Contributor

@petehannam There's no process other than opening a PR. I'd be happy to review one. This hasn't been a priority internally b/c we never attempt shutdown/startup cycles. I understand it would help address problems that you and other have, so it seems worthy of inclusion.

@mattrjacobs
Copy link
Contributor

Closing due to inactivity. Please re-open if there's more to discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants