feat(taro-runtime): consistent window object #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chen-jj
requested changes
Dec 4, 2020
| @@ -9,10 +9,16 @@ export const window = isBrowser ? win : { | |||
| document | |||
| } | |||
|
|
|||
| if (!isBrowser) { | |||
| Reflect.ownKeys(global).forEach(property => { | |||
There was a problem hiding this comment.
Reflect 并不是所有小程序框架在所有机型都兼容，这里需要修改下。
There was a problem hiding this comment.
@Chen-jj 改用 getOwnPropertyNames、getOwnPropertySymbols 来枚举 global 属性了
|
ci 挂了，但是应该跟这个 pr 无关 |
Chen-jj
approved these changes
Dec 11, 2020
|
感谢贡献～ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：
close #8021