fix(h5): 修复 video methods #7891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/helsonxiao/taro-tiktok |
helsonxiao
commented
Oct 22, 2020
| const parentTagName = parentElement.tagName | ||
| if (this.isFullScreen) { | ||
| if (parentTagName !== 'BODY') { | ||
| parentElement.removeChild(this.el) |
There was a problem hiding this comment.
这一段我没理解原来想做什么，对于全屏以及退出全屏我没测出有影响，反而导致了 Safari 上全屏后自动退出。我先全删了。
ZakaryCode
reviewed
Oct 22, 2020
| const timestamp = new Date().getTime() | ||
| if (!e.detail && this.isFullScreen && !document[screenFn.fullscreenElement] && timestamp - this.fullScreenTimestamp > 100) { | ||
| this.toggleFullScreen(false) | ||
| } | ||
| } | ||
|
|
||
| @Listen('fullscreenchange') onNativeFullScreenChange (e) { |
There was a problem hiding this comment.
这里没必要监听这么多个，挺冗余的，用screenFn判断下监听吧
ZakaryCode
reviewed
Oct 22, 2020
| pauseFunc={this.pause} | ||
| playFunc={this.play} | ||
| seekFunc={this.seek} | ||
| pauseFunc={() => this.pause()} |
There was a problem hiding this comment.
我加一些测试吧，现在处于 this 指向有问题，不能工作的状态。这里更改的原因是因为 this.pause 现在已经不是箭头函数了，如下。
/** 暂停视频 */
@Method() async pause () {
this.videoRef.pause()
}
上面这段代码说实话我不知道怎么改，才能让 stencil 即正常，这边又不用额外再新创建箭头函数。
There was a problem hiding this comment.
我加了测试，你可以试试直接用 this.play/this.pause/this.seek，在 control bar 里面调用的话 this 是不对的
20 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个 PR 做了什么? (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：