Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tt) : 修复nextProps在shouldComponentUpdate获取不正确的问题 #4978

Closed
wants to merge 5,397 commits into from

Conversation

YuanQuan
Copy link
Contributor

@YuanQuan YuanQuan commented Nov 30, 2019

这个 PR 做了什么? (简要描述所做更改)
shouldComponentUpdate componentWillUpdate 在获取nextProps时会不正确,与微信比对,修改相关联的代码

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue id #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 满足以下需求:

  • 提交到 master 分支
  • Commit 信息遵循 Angular Style Commit Message Conventions
  • 所有测试用例已经通过
  • 代码遵循相关包中的 .eslintrc, .tslintrc, .stylelintrc 所规定的规范
  • 在本地测试可用,不会影响到其它功能

这个 PR 涉及以下平台:

  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 头条小程序
  • QQ 轻应用
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)

其它需要 Reviewer 或社区知晓的内容:

luckyadam and others added 30 commits September 17, 2019 11:07
编译时替换静态资源的正则改成非贪婪模式
* fix: 修复h5环境下plugins-sass配置不生效的问题

* fix: 修复未赋初始值报错的问题
@Chen-jj
Copy link
Contributor

Chen-jj commented Dec 10, 2019

@YuanQuan 怎么样的情况下会不正确,提供一下出错的 demo。

@YuanQuan
Copy link
Contributor Author

自定义组件,实现 shouldComponentUpdate方法,实例如下
shouldComponentUpdate(nextProps: Readonly): boolean {
return !(nextProps.index === this.props.index && nextProps.stock === this.props.stock && nextProps.select === this.props.select && nextProps.name === this.props.name);
}
这里的nextProps的取值不正确

@YuanQuan
Copy link
Contributor Author

@Chen-jj

@Chen-jj
Copy link
Contributor

Chen-jj commented Dec 23, 2019

@YuanQuan 提供一下父子组件代码咯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.