feat(taro): 分享参数增加动态消息相关字段 #4618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
Garfield550
requested changes
Oct 17, 2019
Comment on lines
+8
to
+10
| isUpdatableMessage?: boolean, | ||
| activityId?: string, | ||
| templateInfo?: TemplateInfo |
There was a problem hiding this comment.
可否像上面 withShareTicket 一样为 isUpdatableMessage activityId templateInfo 添加一些注释呢？
https://developers.weixin.qq.com/miniprogram/dev/api/share/wx.updateShareMenu.html
| } | ||
|
|
||
| interface TemplateInfo { | ||
| parameterList: Array<TemplateInfoParameter> |
There was a problem hiding this comment.
parameterList 建议按照微信小程序文档添加上注释。
Comment on lines
+18
to
+19
| name: string, | ||
| value: string |
There was a problem hiding this comment.
name 和 value 也建议添加上注释。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
分享参数增加动态消息相关字段 (简要描述所做更改)
这个 PR 是什么类型? (至少选择一个)
这个 PR 满足以下需求:
这个 PR 涉及以下平台:
其它需要 Reviewer 或社区知晓的内容：