Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 支付宝dataset在事件冒泡时丢失 #15921

Merged
merged 2 commits into from
Jul 10, 2024
Merged

fix: 支付宝dataset在事件冒泡时丢失 #15921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
385e230
fix: 支付宝dataset在事件冒泡时丢失
zhiqingchen Jun 4, 2024
f0fce7a
Merge branch 'main' into fix/alipay-dataset
zhiqingchen Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/taro-runtime/src/dom/event.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,14 @@ export class TaroEvent {
const cacheTarget = this.cacheTarget
if (!cacheTarget) {
const target = Object.create(this.mpEvent?.target || null)
const currentEle = env.document.getElementById(target.dataset?.sid || target.id || null)
// Note：优先判断冒泡场景alipay的targetDataset的sid, 不然冒泡场景target属性吐出不对，其余拿取当前绑定id
const element = env.document.getElementById(target.targetDataset?.sid || target.dataset?.sid || target.id || null)
target.dataset = element !== null ? element.dataset : EMPTY_OBJ

target.dataset = {
...(currentEle !== null ? currentEle.dataset : EMPTY_OBJ),
...(element !== null ? element.dataset : EMPTY_OBJ)
}

for (const key in this.mpEvent?.detail) {
target[key] = this.mpEvent!.detail[key]
Expand Down
Loading