Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 为京东小程序的 Textarea 组件补充 disable-default-padding 属性 #15573

Merged
merged 2 commits into from
Apr 23, 2024

Conversation

ZEJIA-LIU
Copy link
Contributor

这个 PR 做了什么? (简要描述所做更改)
为京东小程序的 Textarea 组件补充 disable-default-padding 属性

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他,请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台(QuickApp)
  • Web 平台(H5)
  • 移动端(React-Native)
  • 鸿蒙(harmony)

Copy link

taro-bot2 bot commented Apr 22, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

1 similar comment
Copy link

taro-bot2 bot commented Apr 22, 2024

欢迎提交 PR~ Taro 非常感谢您对开源事业做出的贡献!🌷🌷🌷

一般 PR 会在一到两周内进行 review,成功合入后会随下一个版本进行发布。

Review 需要耗费大量时间,所以请遵循以下规范,协助我们提高 review 效率🙏🙏🙏

  1. 详细介绍 PR 的背景(非常重要,例如解决了什么问题,该问题如何复现等)
  2. 确保 CI 顺利运行。
  3. 最好能提供对应的测试用例。

为了更好地进行沟通,请加入 Taro 开发者微信群:

@ZEJIA-LIU ZEJIA-LIU requested a review from Chen-jj April 22, 2024 12:26
@ZEJIA-LIU ZEJIA-LIU changed the title Feat/jd mini textarea feat: 为京东小程序的 Textarea 组件补充 disable-default-padding 属性 Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.52%. Comparing base (3633dcc) to head (c879645).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main   #15573    +/-   ##
========================================
  Coverage   58.52%   58.52%            
========================================
  Files         491      491            
  Lines       21885    21885            
  Branches     5621     5621            
========================================
  Hits        12809    12809            
- Misses       7911     8116   +205     
+ Partials     1165      960   -205     
Flag Coverage Δ
taro-cli 63.61% <ø> (+6.21%) ⬆️
taro-runner 46.25% <ø> (ø)
taro-runtime 65.35% <ø> (ø)
taro-web 40.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 48 files with indirect coverage changes

@ZEJIA-LIU ZEJIA-LIU merged commit cc92f7f into main Apr 23, 2024
26 of 27 checks passed
@ZEJIA-LIU ZEJIA-LIU deleted the feat/jd-mini-textarea branch April 23, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants