Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add react-dom/client alias #14473

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix: add react-dom/client alias #14473

merged 3 commits into from
Sep 11, 2023

Conversation

TheKonka
Copy link
Member

@TheKonka TheKonka commented Sep 3, 2023

这个 PR 做了什么? (简要描述所做更改)

设置 react-dom/client alias 为 @tarojs/react

这个 PR 是什么类型? (至少选择一个)

  • 错误修复(Bugfix) issue: fix #
  • 新功能(Feature)
  • 代码重构(Refactor)
  • TypeScript 类型定义修改(Typings)
  • 文档修改(Docs)
  • 代码风格更新(Code style update)
  • 其他，请描述(Other, please describe):

这个 PR 涉及以下平台:

  • 所有小程序
  • 微信小程序
  • 支付宝小程序
  • 百度小程序
  • 字节跳动小程序
  • QQ 轻应用
  • 京东小程序
  • 快应用平台（QuickApp）
  • Web 平台（H5）
  • 移动端（React-Native）
  • 鸿蒙（harmony）

@ZakaryCode ZakaryCode added this to the 3.6.17 milestone Sep 11, 2023
ZakaryCode
ZakaryCode approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@ZakaryCode ZakaryCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZakaryCode ZakaryCode merged commit e42ebd1 into NervJS:next Sep 11, 2023
4 checks passed
@TheKonka TheKonka deleted the fix-react-dom-client branch September 11, 2023 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZakaryCode ZakaryCode ZakaryCode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Mini Program
Status: Done
Milestone
3.6.17
Development

Successfully merging this pull request may close these issues.
2 participants
@TheKonka @ZakaryCode